Ticket 16304 -- Add HTML5 placeholder attribute support to form fields #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -318,13 +318,15 @@ For each field, we describe the default widget used if you don't specify | |||
| Otherwise, all inputs are valid. | |||
| * Error message keys: ``required``, ``max_length``, ``min_length`` | |||
|
|
|||
| Has two optional arguments for validation: | |||
| Has three optional arguments for validation: | |||
There was a problem hiding this comment.
AFAIK, placeholder is not meant for use in validation in any way.
|
While generally I think adding this attribute to form fields is not the best idea, if you do it, it should be consistent. As |
|
Another option could be adding this argument to the Field class and all the HTML elements which could take advantage of this attribute would show it (basically, all the inputs except for radio and checkboxes + textareas). Do you think it's a good approach? |
|
Ticket has been marked as won't fix in lieu of a different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16304, the addition of placeholders to input boxes should be easier than this:
With this change, it will be something like this:
Tests done and docs updated.